Skip to content

Societal MVP Milestone 2#665

Merged
dsm-w3f merged 6 commits intow3f:masterfrom
sctllabs:master
Jan 3, 2023
Merged

Societal MVP Milestone 2#665
dsm-w3f merged 6 commits intow3f:masterfrom
sctllabs:master

Conversation

@gfox1
Copy link
Copy Markdown
Contributor

@gfox1 gfox1 commented Dec 22, 2022

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#1249

Comment thread deliveries/societal-milestone-2.md Outdated
@gfox1
Copy link
Copy Markdown
Contributor Author

gfox1 commented Dec 22, 2022

Hey @0xCaso, thanks looking at this so quick. I have updated the document to only include **Milestone Number:** 2.

Cheers!

@0xCaso
Copy link
Copy Markdown
Contributor

0xCaso commented Dec 22, 2022

I have another quick question: the second deliverable ("Substrate module: DAO Factory") was in the first milestone, as you've written in the deliverable description. However, in the application there is a delivery called "Substrate chain", which is not present in this delivery. Did you integrate it during the first milestone, or did you remove it as a deliverable?

@gfox1
Copy link
Copy Markdown
Contributor Author

gfox1 commented Dec 23, 2022

Hi @0xCaso, yes we completed the Substrate Chain delivery during Milestone 1. In Milestone 1 we created the DAO factory pallets for the "Substrate Module: DAO Factory" submission, but also incorporated other pallets into our node at that time. So in the Milestone 1 submission, you have the full working Societal node, with all the pallets listed in the Milestone 2 Delivery "Substrate Chain". This is why I referenced the Milestone 1 submission for this, as all of those pallets were already incorporated into the node.

@0xCaso
Copy link
Copy Markdown
Contributor

0xCaso commented Dec 23, 2022

Thanks a lot for the clarifications @gfox1!

@gfox1
Copy link
Copy Markdown
Contributor Author

gfox1 commented Dec 23, 2022

@0xCaso No problem!

@dsm-w3f
Copy link
Copy Markdown
Contributor

dsm-w3f commented Dec 27, 2022

@gfox1 thank you for the milestone submission. Please see the evaluation documents and provide proper answers and fixes. After that, let me know to continue with the evaluation.

@gfox1
Copy link
Copy Markdown
Contributor Author

gfox1 commented Dec 29, 2022

Hi @dsm-w3f, thanks for getting to this so quickly!

We have completed all of the requirements from the notes, except for the article. I will write a medium article over the next few days, publish it and update you. However, I just wanted to let you know about the updates, so you could review the other items in the meantime.

Her are the updates from your notes:

  • Docker:
    We have updated the Milestone 2 submission document and the README to include instructions on the command to run the image.

  • Article:
    Article in progress that will explain what the software is and how to use it.

  • Substrate Project (Milestone 1 Reviewed in Milestone 2)
    We have updated the repo and removed the warnings. No warning should be found while compiling.

  • Frontend (Milestone 2)
    Automated tests have been included.

Please let us know if you have any other issues or questions.

@dsm-w3f
Copy link
Copy Markdown
Contributor

dsm-w3f commented Dec 29, 2022

@gfox1 thank you for the improvements and fixes. I reevaluated the milestone and updated the evaluation document. We are mainly waiting for the article and there is a possible improvement which is creating a docker-compose file to spin up the backend and frontend together. Let me know when I can continue this evaluation.

@gfox1
Copy link
Copy Markdown
Contributor Author

gfox1 commented Jan 2, 2023

Hi @dsm-w3f, we have completed the medium article. Please find the link here.

We have also added the Docker Compose script and added it to the README.

@dsm-w3f
Copy link
Copy Markdown
Contributor

dsm-w3f commented Jan 3, 2023

@gfox1 thank you for the improvements. The milestone delivery was approved. I'll forward your invoice internally and the payment should take place within two weeks (could happen before). Great work!

@dsm-w3f dsm-w3f merged commit d52995d into w3f:master Jan 3, 2023
@gfox1
Copy link
Copy Markdown
Contributor Author

gfox1 commented Jan 3, 2023

@dsm-w3f Great to hear that it has been approved! Thanks for doing this so quickly.

@RouvenP
Copy link
Copy Markdown

RouvenP commented Jan 13, 2023

hi @gfox1 we transferred the payment today.

@gfox1
Copy link
Copy Markdown
Contributor Author

gfox1 commented Jan 13, 2023

Hi @RouvenP, we have received the payment. Thanks so much! Have a good weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants